]> git.neil.brown.name Git - edlib.git/commitdiff
text: don't use Free
authorNeilBrown <neil@brown.name>
Fri, 8 Sep 2023 09:58:25 +0000 (19:58 +1000)
committerNeilBrown <neil@brown.name>
Fri, 8 Sep 2023 09:59:34 +0000 (19:59 +1000)
There is no need to delay freeing of names to Free - do it in Close.

Signed-off-by: NeilBrown <neil@brown.name>
doc-text.c

index 0a3158766753c392b93f993fcba226acd3176ccf..7f4ed19441b04fbf2f019fef8f97a9d6c06a3f2a 100644 (file)
@@ -2521,6 +2521,10 @@ DEF_CMD(text_destroy)
        struct text *t = ci->home->doc_data;
 
        text_cleanout(t);
+       free((void*)t->fname);
+       t->fname = NULL;
+       free((void*)t->autosave_name);
+       t->autosave_name = NULL;
        return Efallthrough;
 }
 
@@ -2544,15 +2548,6 @@ DEF_CMD(text_clear)
        return 1;
 }
 
-DEF_CMD(text_free)
-{
-       struct text *t = ci->home->doc_data;
-
-       free((void*)t->fname);
-       free((void*)t->autosave_name);
-       return 1;
-}
-
 void edlib_init(struct pane *ed safe)
 {
        call_comm("global-set-command", ed, &text_new, 0, NULL,
@@ -2586,6 +2581,5 @@ void edlib_init(struct pane *ed safe)
        key_add(text_map, "debug:validate-marks", &text_val_marks);
 
        key_add(text_map, "Close", &text_destroy);
-       key_add(text_map, "Free", &text_free);
        key_add(text_map, "get-attr", &text_get_attr);
 }