Minor comments etc

Signed-off-by: NeilBrown <neilb@suse.de>

diff --git a/README b/README
index 89bc8a858796af73571b3a84c0393dc0181a531f..9c86195f831e2f177f631444d6c781e826551fbd 100644 (file)
--- a/README
+++ b/README
@@ -5097,11 +5097,11 @@ DONE 15ar/ understand what to do about errors in lafs_truncate
 
 15as/ handle errors from lafs_write_super ???
 
-15at/ More wait_queues to wait for different blocks.
-   An array which we hash in to ??
+DONE 15at/ More wait_queues to wait for different blocks.
+    just use wait_on_bit / wake_bit
 
-15au/ How should iocheck_block set the page error?
-       and block_loaded
+DONE 15au/ How should iocheck_block set the page error?
+       and block_loaded <- this gets it right.
 
 15av/ ditto for write errors?
 

diff --git a/io.c b/io.c
index 260e92638b8a0e6059be729a99bfc15bd99900fd..d4380f79800714484754d3364fa49ddffa72e15e 100644 (file)
--- a/io.c
+++ b/io.c
@@ -274,7 +274,6 @@ void lafs_iocheck_block(struct datablock *db, int unlock)
        for (i = 0 ; i < n; i++) {
                if (test_bit(B_IOLock, &blist[i].b.flags))
                        locked++;
-               /* FIXME what about checking uptodate ?? */
        }
        if (!locked && test_and_clear_bit(B_HaveLock, &blist->b.flags))
                havelock = 1;
@@ -581,7 +580,7 @@ lafs_read_block_async(struct datablock *b)
  * if this is a header block, possibly for earlier clusters.
  *
  * Later should attempt to combine multiple blocks into the
- * one bio ... if we can manage the b_endio function properly
+ * one bio ... if we can manage the bi_end_io function properly
  */
 
 static void write_block(struct fs *fs, struct page *p, int offset,