From ad01acce1b6eb1bcba5b7784c54b43cb1cef1a81 Mon Sep 17 00:00:00 2001 From: NeilBrown Date: Sat, 2 Oct 2010 12:51:50 +1000 Subject: [PATCH] Minor comments etc Signed-off-by: NeilBrown --- README | 8 ++++---- io.c | 3 +-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/README b/README index 89bc8a8..9c86195 100644 --- a/README +++ b/README @@ -5097,11 +5097,11 @@ DONE 15ar/ understand what to do about errors in lafs_truncate 15as/ handle errors from lafs_write_super ??? -15at/ More wait_queues to wait for different blocks. - An array which we hash in to ?? +DONE 15at/ More wait_queues to wait for different blocks. + just use wait_on_bit / wake_bit -15au/ How should iocheck_block set the page error? - and block_loaded +DONE 15au/ How should iocheck_block set the page error? + and block_loaded <- this gets it right. 15av/ ditto for write errors? diff --git a/io.c b/io.c index 260e926..d4380f7 100644 --- a/io.c +++ b/io.c @@ -274,7 +274,6 @@ void lafs_iocheck_block(struct datablock *db, int unlock) for (i = 0 ; i < n; i++) { if (test_bit(B_IOLock, &blist[i].b.flags)) locked++; - /* FIXME what about checking uptodate ?? */ } if (!locked && test_and_clear_bit(B_HaveLock, &blist->b.flags)) havelock = 1; @@ -581,7 +580,7 @@ lafs_read_block_async(struct datablock *b) * if this is a header block, possibly for earlier clusters. * * Later should attempt to combine multiple blocks into the - * one bio ... if we can manage the b_endio function properly + * one bio ... if we can manage the bi_end_io function properly */ static void write_block(struct fs *fs, struct page *p, int offset, -- 2.43.0