getcmptok: fix smatch warning

I don't think smatch can check safety of second-order pointer yet.

Signed-off-by: NeilBrown <neil@brown.name>

diff --git a/core-attr.c b/core-attr.c
index 1d554798057d161e7606645a0f382deec67e2c9e..4f02f290af6eec56ca5824608d5d365b405c4c62 100644 (file)
--- a/core-attr.c
+++ b/core-attr.c
@@ -64,9 +64,15 @@ static struct attrset *newattr(struct attrset *old, int size) safe
  */
 static int getcmptok(char **ap safe)
 {
-       char *a safe = *ap;
-       char c = *a++;
+       char *a safe;
+       char c;
        int i;
+
+       if (!*ap)
+               /* FIXME smatch should handle "char * safe *ap safe" */
+               return 0;
+       a = *ap;
+       c = *a++;
        if (!isdigit(c)) {
                *ap = a;
                return c;