list-objects: drop name_path entirely

In the previous commit, we left name_path as a thin wrapper
around a strbuf. This patch drops it entirely. As a result,
every show_object_fn callback needs to be adjusted. However,
none of their code needs to be changed at all, because the
only use was to pass it to path_name(), which now handles
the bare strbuf.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index c067107a6a6b8d6f797854d1e3a7cc9ce5da0cdc..c886258b75ab9bf0bf34789b67028c35c4c98071 100644 (file)
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -2285,7 +2285,7 @@ static void show_commit(struct commit *commit, void *data)
 }
 
 static void show_object(struct object *obj,
-                       const struct name_path *path, const char *last,
+                       struct strbuf *path, const char *last,
                        void *data)
 {
        char *name = path_name(path, last);
@@ -2480,7 +2480,7 @@ static int get_object_list_from_bitmap(struct rev_info *revs)
 }
 
 static void record_recent_object(struct object *obj,
-                                const struct name_path *path,
+                                struct strbuf *path,
                                 const char *last,
                                 void *data)
 {

diff --git a/builtin/rev-list.c b/builtin/rev-list.c
index c0b4b53652a39049ec06ba69f2dfc50a8c0873f7..3d3a2665f1c94841fa78e45ff2d5511c489c0c36 100644 (file)
--- a/builtin/rev-list.c
+++ b/builtin/rev-list.c
@@ -178,7 +178,7 @@ static void finish_commit(struct commit *commit, void *data)
 }
 
 static void finish_object(struct object *obj,
-                         const struct name_path *path, const char *name,
+                         struct strbuf *path, const char *name,
                          void *cb_data)
 {
        struct rev_list_info *info = cb_data;
@@ -189,7 +189,7 @@ static void finish_object(struct object *obj,
 }
 
 static void show_object(struct object *obj,
-                       const struct name_path *path, const char *component,
+                       struct strbuf *path, const char *component,
                        void *cb_data)
 {
        struct rev_list_info *info = cb_data;

diff --git a/list-objects.c b/list-objects.c
index dc46b9a2b31b7bd0a4957025516f7fd950bf6038..0d56b50a15888e3854843103b4e2d9b84d8b87b9 100644 (file)
--- a/list-objects.c
+++ b/list-objects.c
@@ -11,7 +11,7 @@
 static void process_blob(struct rev_info *revs,
                         struct blob *blob,
                         show_object_fn show,
-                        struct name_path *path,
+                        struct strbuf *path,
                         const char *name,
                         void *cb_data)
 {
@@ -52,7 +52,7 @@ static void process_blob(struct rev_info *revs,
 static void process_gitlink(struct rev_info *revs,
                            const unsigned char *sha1,
                            show_object_fn show,
-                           struct name_path *path,
+                           struct strbuf *path,
                            const char *name,
                            void *cb_data)
 {
@@ -69,7 +69,6 @@ static void process_tree(struct rev_info *revs,
        struct object *obj = &tree->object;
        struct tree_desc desc;
        struct name_entry entry;
-       struct name_path me;
        enum interesting match = revs->diffopt.pathspec.nr == 0 ?
                all_entries_interesting: entry_not_interesting;
        int baselen = base->len;
@@ -87,8 +86,7 @@ static void process_tree(struct rev_info *revs,
        }
 
        obj->flags |= SEEN;
-       me.base = base;
-       show(obj, &me, name, cb_data);
+       show(obj, base, name, cb_data);
 
        strbuf_addstr(base, name);
        if (base->len)
@@ -113,12 +111,12 @@ static void process_tree(struct rev_info *revs,
                                     cb_data);
                else if (S_ISGITLINK(entry.mode))
                        process_gitlink(revs, entry.sha1,
-                                       show, &me, entry.path,
+                                       show, base, entry.path,
                                        cb_data);
                else
                        process_blob(revs,
                                     lookup_blob(entry.sha1),
-                                    show, &me, entry.path,
+                                    show, base, entry.path,
                                     cb_data);
        }
        strbuf_setlen(base, baselen);

diff --git a/list-objects.h b/list-objects.h
index 136a1da5a6f048c0f4645112cdbf29c7b0982526..69c4c7de6efef0e6faa21a10438ea362b151e623 100644 (file)
--- a/list-objects.h
+++ b/list-objects.h
@@ -2,7 +2,7 @@
 #define LIST_OBJECTS_H
 
 typedef void (*show_commit_fn)(struct commit *, void *);
-typedef void (*show_object_fn)(struct object *, const struct name_path *, const char *, void *);
+typedef void (*show_object_fn)(struct object *, struct strbuf *, const char *, void *);
 void traverse_commit_list(struct rev_info *, show_commit_fn, show_object_fn, void *);
 
 typedef void (*show_edge_fn)(struct commit *);

diff --git a/pack-bitmap-write.c b/pack-bitmap-write.c
index c05d1386af7210e75a1012f3772745315ecc3592..e49255df6c1a036b6d5f053c63b94884e0fa169a 100644 (file)
--- a/pack-bitmap-write.c
+++ b/pack-bitmap-write.c
@@ -148,7 +148,7 @@ static uint32_t find_object_pos(const unsigned char *sha1)
        return entry->in_pack_pos;
 }
 
-static void show_object(struct object *object, const struct name_path *path,
+static void show_object(struct object *object, struct strbuf *path,
                        const char *last, void *data)
 {
        struct bitmap *base = data;

diff --git a/pack-bitmap.c b/pack-bitmap.c
index 637770af813eee643c8375051e419715f56a2db5..d12e56511a198e1521c8c7bbe5580a5c725c1fa6 100644 (file)
--- a/pack-bitmap.c
+++ b/pack-bitmap.c
@@ -422,7 +422,7 @@ static int ext_index_add_object(struct object *object, const char *name)
        return bitmap_pos + bitmap_git.pack->num_objects;
 }
 
-static void show_object(struct object *object, const struct name_path *path,
+static void show_object(struct object *object, struct strbuf *path,
                        const char *last, void *data)
 {
        struct bitmap *base = data;
@@ -903,7 +903,7 @@ struct bitmap_test_data {
 };
 
 static void test_show_object(struct object *object,
-                            const struct name_path *path,
+                            struct strbuf *path,
                             const char *last, void *data)
 {
        struct bitmap_test_data *tdata = data;

diff --git a/reachable.c b/reachable.c
index 69fa6851da8a37540da66faf96c7bc878fdc53c9..4379d1ac79c4a54a30af3c22f1f756569977fb75 100644 (file)
--- a/reachable.c
+++ b/reachable.c
@@ -36,7 +36,7 @@ static int add_one_ref(const char *path, const unsigned char *sha1, int flag, vo
  * The traversal will have already marked us as SEEN, so we
  * only need to handle any progress reporting here.
  */
-static void mark_object(struct object *obj, const struct name_path *path,
+static void mark_object(struct object *obj, struct strbuf *path,
                        const char *name, void *data)
 {
        update_progress(data);

diff --git a/revision.c b/revision.c
index f8c30341ed079d5a91844cabb13a1b8a21f715f1..1ff6709d4be716e2f5931a2f9d497510e8fe9935 100644 (file)
--- a/revision.c
+++ b/revision.c
@@ -21,17 +21,17 @@
 
 volatile show_early_output_fn_t show_early_output;
 
-char *path_name(const struct name_path *path, const char *name)
+char *path_name(struct strbuf *path, const char *name)
 {
        struct strbuf ret = STRBUF_INIT;
        if (path)
-               strbuf_addbuf(&ret, path->base);
+               strbuf_addbuf(&ret, path);
        strbuf_addstr(&ret, name);
        return strbuf_detach(&ret, NULL);
 }
 
 void show_object_with_name(FILE *out, struct object *obj,
-                          const struct name_path *path, const char *component)
+                          struct strbuf *path, const char *component)
 {
        char *name = path_name(path, component);
        char *p;

diff --git a/revision.h b/revision.h
index 5e3c47cb489776a832297af9749b875818cf74b7..3a4cf9e61b147d814956c4d67476138bc6e4861f 100644 (file)
--- a/revision.h
+++ b/revision.h
@@ -256,14 +256,10 @@ extern void put_revision_mark(const struct rev_info *revs,
 extern void mark_parents_uninteresting(struct commit *commit);
 extern void mark_tree_uninteresting(struct tree *tree);
 
-struct name_path {
-       struct strbuf *base;
-};
-
-char *path_name(const struct name_path *path, const char *name);
+char *path_name(struct strbuf *path, const char *name);
 
 extern void show_object_with_name(FILE *, struct object *,
-                                 const struct name_path *, const char *);
+                                 struct strbuf *, const char *);
 
 extern void add_pending_object(struct rev_info *revs,
                               struct object *obj, const char *name);