]> git.neil.brown.name Git - linux.git/commitdiff
scsi: mpt3sas: Do not mark fw_event workqueue as WQ_MEM_RECLAIM
authorHannes Reinecke <hare@suse.de>
Mon, 26 Feb 2018 14:26:01 +0000 (15:26 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 7 Mar 2018 03:07:23 +0000 (22:07 -0500)
The firmware event workqueue should not be marked as WQ_MEM_RECLAIM
as it's doesn't need to make forward progress under memory pressure.
In the current state it will result in a deadlock if the device had been
forcefully removed.

Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Acked-by: Sreekanth Reddy <Sreekanth.Reddy@broadcom.com>
Signed-off-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_scsih.c

index c2ea13c7e37e07b2f273a85ff57b3515de0283c3..a1cb0236c550330a5de690462f5ac48c4a3e8bad 100644 (file)
@@ -10558,7 +10558,7 @@ _scsih_probe(struct pci_dev *pdev, const struct pci_device_id *id)
        snprintf(ioc->firmware_event_name, sizeof(ioc->firmware_event_name),
            "fw_event_%s%d", ioc->driver_name, ioc->id);
        ioc->firmware_event_thread = alloc_ordered_workqueue(
-           ioc->firmware_event_name, WQ_MEM_RECLAIM);
+           ioc->firmware_event_name, 0);
        if (!ioc->firmware_event_thread) {
                pr_err(MPT3SAS_FMT "failure at %s:%d/%s()!\n",
                    ioc->name, __FILE__, __LINE__, __func__);