]> git.neil.brown.name Git - gta04.git/commitdiff
fs/ufs: remove extra superblock write on unmount
authorArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Thu, 12 Jul 2012 13:28:06 +0000 (16:28 +0300)
committerAl Viro <viro@zeniv.linux.org.uk>
Sun, 22 Jul 2012 19:58:14 +0000 (23:58 +0400)
UFS calls 'ufs_write_super()' from 'ufs_put_super()' in order to write the
superblocks to the media. However, it is not needed because VFS calls
'->sync_fs()' before calling '->put_super()' - so by the time we are in
'ufs_write_super()', the superblocks are already synchronized.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/ufs/super.c

index 302f340d0071280adaef9366b98280b18e5dd32a..ae91e0af266429b5c8f5ab26aef2727d97ee4389 100644 (file)
@@ -1238,9 +1238,6 @@ static void ufs_put_super(struct super_block *sb)
                
        UFSD("ENTER\n");
 
-       if (sb->s_dirt)
-               ufs_write_super(sb);
-
        if (!(sb->s_flags & MS_RDONLY))
                ufs_put_super_internal(sb);